Skip to content

feat: trust extensions - #98

Merged
alienvspredator merged 1 commit into
mainfrom
feature/trust-extensions
Jun 22, 2026
Merged

feat: trust extensions#98
alienvspredator merged 1 commit into
mainfrom
feature/trust-extensions

Conversation

@alienvspredator

@alienvspredator alienvspredator commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Setup trust with an extensible OIDC flow.

Special notes for your reviewer:

This PR does not introduce breaking changes, instead, it introduces new packages intended to replace some of the existing ones.

The packages, messages, and methods that are the subject to deprecate are marked as deprecated with a respective `option deprecated = true`.

Release note:

- Define `kms.api.cmk.sessionmanager.trustmapping.v1` package.
- Define `kms.api.cmk.trust.oidc.v1` and `kms.api.cmk.trust.oidc.flow.v1` packages.
- Define `kms.api.cmk.sessionmanager.session.v1.Service/GetTrust` method.
- Deprecate `kms.api.cmk.sessionmanager.session.v1.Service/GetOIDCMapping` method in favour of `GetTrust`.
- Deprecate `kms.api.cmk.sessionmanager.oidcmapping.v1` package.
- Deprecate `kms.api.cmk.types.v1.OIDCProvider` message.
- Update protovalidate to v1.2.0.

feat: trust mapping

@coderabbitai

coderabbitai Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 92cdfb76-f881-457b-b29d-194a659b342a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 22, 2026, 9:00 AM

@alienvspredator
alienvspredator force-pushed the feature/trust-extensions branch from 3324ecf to a872a7e Compare May 18, 2026 09:38
@openkcm openkcm deleted a comment from coderabbitai Bot May 18, 2026
@alienvspredator
alienvspredator force-pushed the feature/trust-extensions branch 2 times, most recently from 546d918 to 4c441e4 Compare May 26, 2026 06:55
cb80
cb80 reviewed May 26, 2026
View reviewed changes
Comment thread proto/kms/api/cmk/trust/oidc/v1/oidc.proto Outdated
Comment thread proto/kms/api/cmk/sessionmanager/trustmapping/v1/trustmapping.proto
Comment thread proto/kms/api/cmk/sessionmanager/trustmapping/v1/trustmapping.proto Outdated
@alienvspredator
alienvspredator force-pushed the feature/trust-extensions branch 6 times, most recently from dfb48ad to 1fae517 Compare May 26, 2026 13:26
@alienvspredator
feat: trust mapping
c189534 
feat: setup extensible trust
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
@alienvspredator
alienvspredator force-pushed the feature/trust-extensions branch from 1fae517 to c189534 Compare June 22, 2026 09:00
@alienvspredator
alienvspredator merged commit 03cce43 into main Jun 22, 2026
9 checks passed
@alienvspredator
alienvspredator deleted the feature/trust-extensions branch June 22, 2026 09:02
@push-tags-from-workflow push-tags-from-workflow Bot mentioned this pull request Jun 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cb80 cb80 cb80 approved these changes
@pabloszel11 pabloszel11 pabloszel11 approved these changes

Assignees

No one assigned

Labels

api feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alienvspredator @cb80 @pabloszel11